NIFI-16226 - Parameter Context update fails when adding provider-backed inheritance in a cluster - #11562
NIFI-16226 - Parameter Context update fails when adding provider-backed inheritance in a cluster#11562pvillard31 wants to merge 3 commits into
Conversation
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for addressing this issue @pvillard31. I noted one question around inherited parameter handling.
…ed inheritance in a cluster
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the updates @pvillard31. On further review, there still appear to be some edge cases, particularly with handling of sensitive parameter values.
| } else { | ||
| parameterEntity = dtoFactory.createParameterEntity(parameterContext, parameter, revisionManager, parameterContextDAO); | ||
| final Parameter entityParameter = locallyOwned ? localParameters.get(parameterDescriptor) : parameter; | ||
| parameterEntity = dtoFactory.createParameterEntity(parameterContext, entityParameter, revisionManager, parameterContextDAO); |
There was a problem hiding this comment.
This appears to be a latent issue, but createParameterEntity() calls createParameterDto(), which substitutes a hard-coded mask string when the Parameter is marked as sensitive. This seems like it will cause issues when persisting the values.
| parameterEntity.setParameter(parameterDTO); | ||
| } else { | ||
| parameterEntity = dtoFactory.createParameterEntity(parameterContext, parameter, revisionManager, parameterContextDAO); | ||
| final Parameter entityParameter = locallyOwned ? localParameters.get(parameterDescriptor) : parameter; |
There was a problem hiding this comment.
It looks like this introduces a discrepancy for how the parameter checking occurs when adding inheritance. This keeps the original value and requested value as the parameter reference #{ParameterName}, but that avoids triggering any changes.
2 participants
Summary
NIFI-16226 - Parameter Context update fails when adding provider-backed inheritance in a cluster
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation