Fix Java reformatter for empty records and nested lambdas

[neilcsmith-net]

Fixes for two niggles in the reformatter - empty record bodies and nested lambda continuation indents.

Empty records

Where a record has an empty body with no whitespace -

record Foo(int x) {}

Stop the reformatter turning this into -

record Foo(int x) {

}

This change keeps the original code intact while reformatting all non-empty bodies as before. The change only affects the default same-line brace placement. The other modes are somewhat broken with records already.

NB. The classLeftBracePlacement method is removed and the code added to the record handling. Despite its name, this isn't used for non-record classes anyway, and while the intention might have been to allow code reuse, the method isn't correct for this.

Nested lambda continuations

Where code has nested lambdas, such as -

public static void main(String[] args) {
    List<String> lines = Stream.of(args)
            .flatMap(s -> s.lines()
                    .filter(l -> !l.isBlank())
            ).toList();
}

Stop the reformatter from flattening the continuation indents -

public static void main(String[] args) {
    List<String> lines = Stream.of(args)
            .flatMap(s -> s.lines()
            .filter(l -> !l.isBlank())
            ).toList();
}

This behaviour is already correct if wrapAfterLambdaArrow is set, but not in the default case.

[dbalek]

Looks reasonable. Thanks.

[matthiasblaesing]

Thank you! Especially the record formatting annoyed the hell out of me, so great to see this fixed!

For the same line setting this looks what I would expect, but "Class Declaration: New Line" causes a strange formatting (here record in contrast to the class). I think the opening brace for the record should be in the same column as the closing one:

For "New Line Half Indented" the opening brace is to far right and the closing one is not far enough on the right:

For "New Line Indented" the situation is the same, just the opening brace is further to far right.

[neilcsmith-net]

Thanks @matthiasblaesing Yes, as I said, the other modes are somewhat broken already. This should be the same behaviour as recent releases? I've tried not to touch them for now. If it's not a regression I would prefer to consider as a follow up issue. There's a bit more to think about what to do with them if they're empty (new line may be odd for that), and we need some tests for those other modes.

[matthiasblaesing]

@neilcsmith-net a sorry I overlooked that remark. And yes, the brokenness is identical before and after the change, so ignore that part of my comment.

[neilcsmith-net]

Thanks for reviews. Going to merge this. Will take a look at what's happening with the other brace modes shortly. Ideal approach might be to peek ahead to search for {} before deciding on whether to add the new line or not? Although I need to look up how to do that in this content!

[neilcsmith-net]

@matthiasblaesing hopefully #9480 addresses the issues about alternative brace position modes.