Skip to content

SslIdentificationAlgorithmTest - do not resolve DNS for custom hostnames - #65

Merged
the-thing merged 2 commits into
apache:2.2.Xfrom
the-thing:fix-dns-resolution-for-dns-id
Sep 22, 2026
Merged

the-thing merged 2 commits into
apache:2.2.Xfrom
the-thing:fix-dns-resolution-for-dns-id

Conversation

@the-thing

Copy link
Copy Markdown
Member

This test fails on my machine. DNS hostname resolution can timeout for fake SNI hostnames, which causes the tests to fail. We don't want to resolve them for testing purposes.

Can you not merge this request please? I will try to merge it myself in a couple of days (unless rejected). Thanks.

@elecharny

Copy link
Copy Markdown
Contributor

You own this PR :-)

Just wondering if we could have a TLS v1.3 version too?

@the-thing the-thing self-assigned this Sep 22, 2026
@the-thing

Copy link
Copy Markdown
Member Author

@elecharny

I added parametrized test for for TLS 1.2 and 1.3.

What do we do know? Cleary the test failures are not related. Is it ok to merge? I will be targeting other tests in the future.

org.apache.mina.transport.socket.nio.DatagramSessionIdleTest
org.apache.mina.transport.socket.nio.DIRMINA777Test

@elecharny

elecharny commented Sep 22, 2026 via email

Copy link
Copy Markdown
Contributor

@the-thing
the-thing merged commit 69720a2 into apache:2.2.X Sep 22, 2026
6 of 9 checks passed
@the-thing
the-thing deleted the fix-dns-resolution-for-dns-id branch September 22, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants