SslIdentificationAlgorithmTest - do not resolve DNS for custom hostnames - #65
Merged
Merged
Conversation
Contributor
|
You own this PR :-) Just wondering if we could have a TLS v1.3 version too? |
Member
Author
|
I added parametrized test for for TLS 1.2 and 1.3. What do we do know? Cleary the test failures are not related. Is it ok to merge? I will be targeting other tests in the future.
|
Contributor
|
Hi Marcin,
sure, go and merge. If it breaks something, we can fix it or revert it.
This is why we use a VCS, aren't we ? ;-)
…On Tue, Sep 22, 2026 at 3:33 PM Marcin L ***@***.***> wrote:
*the-thing* left a comment (apache/mina#65)
<#65 (comment)>
@elecharny <https://github.com/elecharny>
I added parametrized test for for TLS 1.2 and 1.3.
What do we do know? Cleary the test failures are not related. Is it ok to
merge? I will be targeting other tests in the future.
org.apache.mina.transport.socket.nio.DatagramSessionIdleTest
org.apache.mina.transport.socket.nio.DIRMINA777Test
—
Reply to this email directly, view it on GitHub
<#65?email_source=notifications&email_token=AAWJQFJOBNHY6MB2ZIDNAFL5QJ5TXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZXG42DOOBUGMZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5777478433>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWJQFJFFI6AJUNUZ5IVFA35QJ5TXAVCNFSNUABCKJSXA33TNF2G64TZHMZDANRTGY3DWSLTON2WKOZVGUZTOOJUGU3TCONBOYBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Regards,
Cordialement,
Emmanuel Lécharny
www.worteks.com <http://www.iktek.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails on my machine. DNS hostname resolution can timeout for fake SNI hostnames, which causes the tests to fail. We don't want to resolve them for testing purposes.
Can you not merge this request please? I will try to merge it myself in a couple of days (unless rejected). Thanks.