Conversation
Rebuild tool validation from the current transaction's local dependency closure, removing the retained reducer cache and its consistency protocol. Remove recovery profiling wrappers and keep fonts as local CSP-safe assets. Add mixed tool/steering restart checks and a reusable correctness runner. Refs apache#5613 Generated-by: OpenAI Codex
Keep the startup correctness file inventory visible to the release contract checker. Remove dynamic path construction without changing any selected test or group. Generated-by: OpenAI Codex
Keep the self-contained correctness runner and generated-data regression tests in the PR. Retain the handoff document only as local validation material. Generated-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5613. Follow-up to #5556, based on main including #5606 and #5608.
Tool writes now reconstruct validation state from the current SQLite transaction, scoped to the invocation and explicit parent dependencies. Remove the cross-transaction reducer cache and its LRU/budgets, checkpoint/undo, invalidation versions and settlement synchronization. Scans and writes retain shared validation rules, corruption classification and exact retry semantics. Also remove the leftover
MAKA_STARTUP_PROFILEtiming layer from SessionManager recovery.The trade-off is deliberate: the previous same-base ablation retained the startup improvement, while a synthetic single invocation with 200 uninterrupted tool executions was slower without caching (615→1249 ms for 512 B; 839→2056 ms for 4 KiB). Short invocations and heavily interleaved partial writes showed smaller or unstable benefits; some intermediate patterns still benefit. We accept that local cost to remove long-lived consistency obligations whose representative end-to-end value has not been established. These are prior measurements on
518fd529c0, not new performance claims for this PR's base.Keep bundled fonts as local assets so KaTeX history rendering respects the existing CSP. The memory/model-connection startup readiness fix is already supplied by #5606 on main.
Add two real Host/SQLite regression journeys: mixed prepared/committed/unknown tool outcomes recover once; consumed quoted steering survives SIGKILL without duplicate echo or old-epoch replay. Run both with 1k and 100k background events, checking history digests and repeated recovery.
npm run test:startup-correctnessgroups these with existing storage, tool, queue, background-task and Desktop contracts. Local benchmark drivers, databases and generated reports are excluded.Verification
npm run buildandnpm run typecheck: passed on the updated base.npm run check:release: 203 passed after making the correctness runner's test file paths explicit; all 7 groups and 36 file entries are unchanged.npx knip --workspace apps/desktopandnpx knip --workspace packages/ui: passed.npm run test:startup-correctness -- --skip-build: 546 passed, 0 failed/skipped, including both 100k journeys. SessionManager/Graph direct regression: 212 passed.status=ok, connection catalog available, KaTeX font loaded; error toast / renderer error / awaitReady error counts were0 / 0 / 0in every run. Each owned Host exited cleanly.AI use
Tool(s) and scope: OpenAI Codex implemented the simplification and font fix, authored the mixed-state tests and runner, ran validation, and prepared this submission at @testikun's request. @testikun is the human contributor of record; final review and merge remain with humans.
Checklist
Does this PR entail a change in behavior?