Skip to content

fix(desktop): stabilize composer during session switches and resizing - #5513

Draft
colaforniaw wants to merge 2 commits into
apache:mainfrom
colaforniaw:fix/composer-session-switch-stability
Draft

colaforniaw wants to merge 2 commits into
apache:mainfrom
colaforniaw:fix/composer-session-switch-stability

Conversation

@colaforniaw

@colaforniaw colaforniaw commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Switching Sessions could briefly show controls from the previous Session, while narrow Composer widths could compress the footer into the send button. An empty Composer could also show the branch icon through the translucent disabled Send button.

This change keeps the Composer footer on one row with a 520px minimum conversation width, preserves fixed space for Send, prevents stale session branch state from painting during a switch, and gives the Send/Stop slot an opaque backing while keeping the existing disabled appearance.

The Workbar remains under user control; narrow widths do not automatically move or collapse it.

Before / After

Scenario Before After
Narrow window: Composer footer in desktop placeholder
after-responsive.mp4
Narrow window: Composer footer in workhub placeholder
workhub-responsive-after.mp4
Session switch: stale controls and usage flicker placeholder
switch-after.mp4

Verification

  • Manual visual verification confirmed the Composer remains single-line, the Send button no longer reveals the branch icon, and Session switching no longer shows stale branch state.
  • git diff --check passed.
  • npm --workspace @maka/desktop run check:architecture -- --base d0dd3edf202f120c5ea950825160dfd02b426145 --strict-base passed, including 112 architecture checker tests.
  • Final typecheck and focused tests were not rerun after the last visual fixes; they should be run before merge.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex assisted with the Composer behavior, layout, usage state, and regression coverage. The commit carries Generated-by: Codex.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/L Under 1000 readable lines label Sep 19, 2026
@colaforniaw
colaforniaw force-pushed the fix/composer-session-switch-stability branch 7 times, most recently from 0b97612 to fd18a8a Compare September 22, 2026 02:27
@github-actions github-actions Bot added effort/XL Under 2500 readable lines and removed effort/L Under 1000 readable lines labels Sep 22, 2026
@colaforniaw
colaforniaw force-pushed the fix/composer-session-switch-stability branch 7 times, most recently from f5b8b50 to 95443a7 Compare September 23, 2026 05:01
@colaforniaw
colaforniaw force-pushed the fix/composer-session-switch-stability branch 3 times, most recently from 5ec2f47 to 45e6d3a Compare September 23, 2026 09:20
@colaforniaw
colaforniaw force-pushed the fix/composer-session-switch-stability branch from 45e6d3a to 616208e Compare September 23, 2026 10:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XL Under 2500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants