fix(specs): correct repo-health family count in triage-mode.md - #1075
Conversation
Why: triage-mode.md said "five-skill family" while repo-health-family.md says the family is six skills deep. The sixth skill, dependency-license-audit, shipped without this spec being updated. The spec-loop plan beat reads Known gaps to choose the next work item, so the two specs disagreeing about a countable fact can send the loop at finished work. Per the maintainer's direction on the issue (Option 1), six read-only audits is the correct count; re-keying audit-finding-fix off family:repo-health is left for a follow-up once the target key is decided. Closes apache#931 Generated-by: Claude Code (Fable 5)
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM. The count is right and, more usefully, the PR is honest about the half it
does not fix.
Verified the six named skills all carry family: repo-health, and that
repo-health-family.md independently says six — so triage-mode.md was the
odd one out, exactly as #931 describes.
On the seventh skill
Counting family: repo-health in frontmatter actually returns seven, not
six — audit-finding-fix carries it too. The issue's "counting the ones set to
repo-health settles the number" hint therefore points at a different answer than
the one landed here, and it would have been easy to follow it literally and
produce a wrong fix.
Six is correct: repo-health-family.md enumerates six read-only audits, and
audit-finding-fix is not read-only. The deferral note is also accurate —
spec-gap-staleness.md lines 201–205 document precisely this as a three-way
discrepancy ("triage-mode claims five, repo-health-family claims six, and seven
carry family: repo-health"), so re-keying audit-finding-fix here would have
invalidated a worked example in another spec. Leaving it for a follow-up is the
right call, and saying so in the PR is what made this quick to review.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
CONTRIBUTING.md § Opening a pull request.
2 participants
Summary
triage-mode.mdcalled repo-health a "five-skill family" whilerepo-health-family.mdsays six. The sixth skill,dependency-license-audit, shipped without this spec being updated. Per the maintainer's direction on the issue (Option 1: six read-only audits is the correct count), this PR updates the count to six and adds the missing skill to the list.Type of change
tools/spec-loop/specs/)Test plan
uv run --project tools/spec-validator spec-validate tools/spec-loop/specs/— OK, no violationsprek run --all-files— all 23 hooks passRFC-AI-0004 compliance
No runtime behaviour or state-changing workflow is changed — spec prose only.
Linked issues
Closes #931
Notes for reviewers (optional)
Scoped to the prose fix only. The other half of Option 1 — re-keying
audit-finding-fixofffamily: repo-health— is left for a follow-up once the target key is decided (it also feeds the three-way-discrepancy example inspec-gap-staleness.md, which a re-key would invalidate).Generative AI disclosure
Prepared with Claude Code (Fable 5). The commit carries a
Generated-by:trailer and no AICo-Authored-By:trailer.