Skip to content

Fix encrypted password pull consumer commit mode#18044

Open
Caideyipi wants to merge 1 commit into
masterfrom
fix/encrypted-password-pull-consumer-commit
Open

Fix encrypted password pull consumer commit mode#18044
Caideyipi wants to merge 1 commit into
masterfrom
fix/encrypted-password-pull-consumer-commit

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

  • Set the encrypted-password pull consumer regression test to manual commit mode.
  • Keep it consistent with consume_data(), which explicitly commits polled messages.
  • Avoid a race where the default auto-commit worker commits the same message before the test's manual commit, causing a partially accepted duplicate commit.

Verification

  • mvn spotless:apply -pl integration-test -P with-integration-tests
  • git diff --check -- integration-test/src/test/java/org/apache/iotdb/subscription/it/triple/treemodel/regression/param/IoTDBEncryptedPasswordPullConsumerIT.java
  • mvn -Ddevelocity.off=true verify -DskipUTs -Dit.test=IoTDBEncryptedPasswordPullConsumerIT#testSubscribeWithEncryptedPassword -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -P with-integration-tests,MultiClusterIT2SubscriptionTreeRegressionMisc (target test was discovered, but skipped locally because the test cluster failed to start: SeedConfigNode not alive / Empty configNode set)

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.43%. Comparing base (7f41f06) to head (be3aef3).

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18044   +/-   ##
=========================================
  Coverage     41.42%   41.43%           
  Complexity      318      318           
=========================================
  Files          5282     5282           
  Lines        369246   369246           
  Branches      47786    47786           
=========================================
+ Hits         152978   153007   +29     
+ Misses       216268   216239   -29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant