IGNITE-28727 Create internal API method to lock cache entry with specific version#13264
Merged
Conversation
63cf3ce to
7284112
Compare
tkalkirill
reviewed
Jun 26, 2026
tkalkirill
left a comment
Contributor
There was a problem hiding this comment.
A few additional general comments:
- Please add tests where a lock is acquired via the new API in one transaction and an attempt is made to acquire it via the new API in another; cover both distinct keys and the same key. It would be great to test this with both single-threaded and multi-threaded scenarios.
- I didn't see a test checking what happens if the new API is called outside of a pessimistic transaction.
- I didn't see a test checking the behavior regarding lock acquisition after the transaction has completed.
4.waitTimeoutExpiresFirstshould be moved to a shared location so there is only one instance of it, accompanied by a clear comment.
Contributor
Author
|
About the text comment above:
|
…metric interceptor keep binary flag.
…ot wait much longer than timeout.
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
tkalkirill
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28727