Build: Replace deprecated Groovy space-assignment property syntax in build scripts - #16579
Build: Replace deprecated Groovy space-assignment property syntax in build scripts#16579wombatu-kun wants to merge 1 commit into
Conversation
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
no stale |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
…build scripts Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1a23a44 to
0341b41
Compare
Closes #15976
Summary
Gradle deprecated the Groovy DSL "space-assignment" syntax for setting properties (e.g.
exceptionFormat "full") in favor of explicit assignment (exceptionFormat = "full"). It currently emitsProperties should be assigned using the 'propName = value' syntax …warnings and is scheduled for removal in Gradle 10. This migrates the remaining space-assignment usages across the build scripts so the build is quiet under--warning-mode alland ready for the eventual Gradle upgrade — the repository was already mostly migrated, and this completes it.Issue: #15976
What changed
Converted every remaining space-assignment property setter to
name = value(22 occurrences across 13 build scripts), preserving the existing quote style:exceptionFormat = "full"andmaxHeapSize = '…'in test / test-logging config (build.gradle,mr/build.gradle,spark/v3.5|v4.0|v4.1/build.gradle).zip64 = truein everyshadowJar { }block (build.gradle×2, theaws-/azure-/gcp-bundlebuilds, and the Spark and Flink runtime bundles).group = 'build'on thesourceJar/javadocJartasks andusername =/password =in the Mavencredentials { }block (deploy.gradle).destinationDir = …on theaggregateJavadoctask (tasks.gradle).Genuine method calls that merely resemble the pattern were intentionally left unchanged — e.g.
events "passed", "failed",systemProperty 'k', v,source javadocTasks.source, andconfigurations = [...](already correct). Unrelated deprecation categories (e.g.JavaPluginConventionfrom plugins, reserved configuration names) are out of scope for this issue.Tests
This is a build-script syntax migration with no runtime behavior change, so no unit tests apply. Verified by
./gradlew help --warning-mode all -DallModules=true— configures every Spark/Flink/Kafka/Scala module with BUILD SUCCESSFUL and zeropropName = valuewarnings remaining (a clean configure also proves each conversion targets a real settable property) — and by./gradlew :iceberg-core:test --tests "org.apache.iceberg.TestTableMetadata.testJsonConversion" --warning-mode all, confirming the convertedtest/testLoggingconfig still runs at execution time.AI Disclosure