Port pure utility classes with no Spark SQL dependency - #159
Conversation
|
|
||
| import org.apache.yetus.audience.InterfaceAudience | ||
|
|
||
| @InterfaceAudience.Private |
There was a problem hiding this comment.
nit: The original Bound.scala had some doc. For example inc. I let you decide if those add extra readability to the code.
| import org.apache.yetus.audience.InterfaceAudience | ||
|
|
||
| @InterfaceAudience.Public | ||
| object HBaseSparkConf { |
There was a problem hiding this comment.
nit: The config comments could be useful.
| import org.apache.yetus.audience.InterfaceAudience | ||
|
|
||
| @InterfaceAudience.Private | ||
| class NaiveEncoder extends BytesEncoder with Logging { |
There was a problem hiding this comment.
What is the purpose of the removal of debog logs? If you intend to drop logging then you'd probably want to remove the with Logging as well.
| import org.apache.yetus.audience.InterfaceAudience | ||
|
|
||
| @InterfaceAudience.Private | ||
| class NaiveEncoder extends BytesEncoder with Logging { |
There was a problem hiding this comment.
Consider adding back the comments.
| Bytes.putDouble(result, 1, value.asInstanceOf[Double]) | ||
| result | ||
| case BinaryType => | ||
| val v = value.asInstanceOf[Array[Byte]] |
There was a problem hiding this comment.
Is this intentional? Original had val v = value.asInstanceOf[Array[Bytes]] (Byte vs. Bytes)
Does it need a bugfix for the old class?
There was a problem hiding this comment.
Yes, this is a bug in the spark3 module. Will include a fix.
2 participants
No description provided.