[GLUTEN-13062][VL] Clamp madvise(MADV_WILLNEED) length against posFetch_ to avoid EINVAL in MmapFileStream - #13063
Open
jiangjiangtian wants to merge 1 commit into
Open
jiangjiangtian wants to merge 1 commit into
jiangjiangtian wants to merge 1 commit into
Conversation
…INVAL in MmapFileStream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13062.
The fetch starts at
posFetch_, so clamp the fetch length againstsize_ - posFetch_instead ofsize_ - pos_. This keepsposFetch_either page-aligned or exactly atsize_(after which no further fetch is needed), so everymadvise()call receives a page-aligned address and no advised range overruns the mapping.Besides, after this PR the prefetching will work in all cases, there is a perfermance gain in merging spills of shuffle data.