[MINOR] [CORE] Remove registered executors in soft affinity UT - #13054
Merged
marin-ma merged 1 commit intoSep 21, 2026
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Cleanup must be guaranteed with lifecycle or finally handling if earlier assertions fail.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds executor cleanup to prevent SoftAffinityManager state leaking between soft-affinity tests.
Changes:
- Removes all registered executors at test completion.
- Verifies both executor registries are empty.
File summaries
| File | Description |
|---|---|
gluten-substrait/src/test/scala/org/apache/spark/softaffinity/SoftAffinitySuite.scala |
Adds executor removal and state assertions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+273
to
+277
| executorsListListener.onExecutorRemoved(removedEvent0) | ||
| executorsListListener.onExecutorRemoved(removedEvent1) | ||
| executorsListListener.onExecutorRemoved(removedEvent2) | ||
| executorsListListener.onExecutorRemoved(removedEvent3) | ||
| executorsListListener.onExecutorRemoved(removedEvent4) |
acvictor
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably fix the CI failure in #13039
https://opencicd.kyligence.com/job/gluten/job/gluten-ci/21393/