[GLUTEN-13044][CORE] Fix exceedsMaxMemoryUsage to use actual used heap instead of committed heap - #13045
Open
r7raul1984 wants to merge 1 commit into
Open
[GLUTEN-13044][CORE] Fix exceedsMaxMemoryUsage to use actual used heap instead of committed heap#13045r7raul1984 wants to merge 1 commit into
r7raul1984 wants to merge 1 commit into
Conversation
…p instead of committed heap
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13044
DynamicOffHeapSizingMemoryTarget.exceedsMaxMemoryUsage() previously used Runtime.getRuntime().totalMemory() (committed heap) as the on-heap memory pressure indicator. Committed heap is the memory the JVM has reserved from the OS, which includes a potentially large
amount of free pages that have not yet been returned. As a result, the check overstates memory pressure between Spark stages and triggers spurious OOMs.
Example of the failure:
Fix:
Replace totalMemory() with totalMemory() - freeMemory() (actual used heap) at all four call sites of exceedsMaxMemoryUsage() — three in borrow() and one in shouldTriggerAsyncOnHeapMemoryShrink(). The parameter is renamed from totalOnHeapMemory to usedOnHeapMemory for
clarity.
// Before
exceedsMaxMemoryUsage(totalHeapMemory, usedOffHeapMemory, size, 1.0)
// After
exceedsMaxMemoryUsage(totalHeapMemory - freeHeapMemory, usedOffHeapMemory, size, 1.0)
Note: freeHeapMemory is already read from Runtime.getRuntime().freeMemory() at the top of borrow(), so no additional JVM calls are introduced.
How was this patch tested?
Existing unit tests in DynamicOffHeapSizingMemoryTargetTest (added in #12425) continue to pass. New tests covering the spurious-OOM scenario between stages will be added as a follow-up.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.6, Anthropic