fix(java): define generated serializers as normal classes#3791
fix(java): define generated serializers as normal classes#3791mandrean wants to merge 2 commits into
Conversation
|
Could you check whether fory 1.3.0 still have this issue? I released 1.3.0 today |
|
And I think we should not define generated serializer as hidden class, define it as normal class is enough. I define it as hidden class to access private fields directly, but janino can't compile it. With #3778, field access on jdk25 is not a performance issue anymore. |
c75c0b8 to
5c94ebc
Compare
5c94ebc to
6310e6c
Compare
I moved back the PR to |
Summary
Define generated serializers as normal classes instead of hidden nestmates.
The first commit adds a failing regression test for async serializer JIT with an allow-all TypeChecker. The fix updates neighbor-based codegen to use the normal class definition path and adjusts the JDK 25 class-shape assertion.
Closes #3790
Validation
JITContextTestCodecUtilsTestObjectCodecBuilderTestJITContextTestspotless:checkcheckstyle:check