-
Notifications
You must be signed in to change notification settings - Fork 3.8k
perf(test): cut high-cost CI test latency while preserving coverage #20127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
857bbb7
ed74369
8c71646
5e4c413
279a664
98f308a
618c530
28112d5
afb553e
daa050b
a3fcf7c
584c7db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,7 +94,8 @@ public void test_cancelledWorker_isRetried_ifFaultToleranceIsEnabled() throws Ex | |
| final EmbeddedIndexer faultyIndexer = new EmbeddedIndexer() | ||
| .addProperty("druid.plaintextPort", "7091") | ||
| .addProperty("druid.unsafe.cluster.testing", "true") | ||
| .addProperty("druid.unsafe.cluster.testing.overlordClient.taskStatusDelay", "PT1H") | ||
| // Keep the injected delay short so the retry path is exercised without a one-hour wait. | ||
| .addProperty("druid.unsafe.cluster.testing.overlordClient.taskStatusDelay", "PT1S") | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P2] One-second delay no longer reliably blocks the faulty worker The faulty worker can resume after this delay while the functional indexer is starting, allowing it to finish before cancellation. The FAILED assertion then becomes timing-dependent. Keep the delay longer than setup or synchronize on a state proving the worker remains blocked. |
||
| .addProperty("druid.worker.capacity", "1"); | ||
| cluster.addServer(faultyIndexer); | ||
| faultyIndexer.start(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Batching ignores Kinesis aggregate request-size limit
PutRecords is limited to both 500 records and a 5 MiB aggregate payload. A 500-record batch can exceed 5 MiB and be rejected, whereas the previous per-record loop accepted individually valid records. Bound batches by total size as well as count.