[fix](nereids) scale group-by-less global agg cost by BE number when partitioned - #66354
Open
foxtail463 wants to merge 1 commit into
Open
[fix](nereids) scale group-by-less global agg cost by BE number when partitioned#66354foxtail463 wants to merge 1 commit into
foxtail463 wants to merge 1 commit into
Conversation
foxtail463
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
August 1, 2026 17:20
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
foxtail463
force-pushed
the
fix/disinct-no-group-by
branch
from
August 1, 2026 17:21
dd90308 to
19f7f33
Compare
Contributor
TPC-H: Total hot run time: 28674 ms |
Contributor
TPC-DS: Total hot run time: 168752 ms |
Contributor
ClickBench: Total hot run time: 23.9 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
A scalar count(distinct) runs its global aggregate hash-shuffled by the distinct
key (non-empty partitionExpressions), i.e. in parallel across BEs. But the cost
model set the parallelism factor from group-by keys alone, so with no group by it
used factor = 1, costing the aggregate as single-point. This overestimated the
parallel plan and made CBO reject it.
Solution:
Treat a global aggregate as partitioned when it has group by keys or non-empty
partitionExpressions, and scale its cost by beNumber accordingly.