branch-4.1: [chore](paimon) Upgrade Paimon to 1.4.2 - #66346
branch-4.1: [chore](paimon) Upgrade Paimon to 1.4.2#66346suxiaogang223 wants to merge 3 commits into
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
Gabriel39
left a comment
There was a problem hiding this comment.
I found one planning-path performance regression in the Paimon 1.4 API adaptation. Please keep the merged-row-count computation guarded by COUNT(*) pushdown and add regression coverage for non-count scans.
| Optional<List<DeletionFile>> optDeletionFiles = dataSplit.deletionFiles(); | ||
| if (applyCountPushdown && dataSplit.mergedRowCountAvailable()) { | ||
| splitStat.setMergedRowCount(dataSplit.mergedRowCount()); | ||
| OptionalLong mergedRowCount = dataSplit.mergedRowCount(); |
There was a problem hiding this comment.
mergedRowCount() is now evaluated for every DataSplit, even when applyCountPushdown is false. In Paimon 1.4.2 this method can call dataEvolutionMergedRowCount(), which builds and sorts file ranges, so ordinary Paimon scans gain avoidable planning work; previously the applyCountPushdown && ... short-circuit skipped it entirely. Please keep this call behind the pushdown guard (for example, use applyCountPushdown ? dataSplit.mergedRowCount() : OptionalLong.empty()) and add a regression test verifying that a non-count scan does not invoke mergedRowCount().
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
What changes
pickTempDir()API.Why
Use the latest stable Paimon release and keep the Doris Paimon connector compatible with its updated IO manager interface.
Validation
DISABLE_BUILD_UI=ON ./build.sh --feBUILD SUCCESS.thirdparty/installed.