Skip to content

[refactor](fe) Remove bilingual descriptions from variable annotations - #66342

Open
lsy3993 wants to merge 3 commits into
apache:masterfrom
lsy3993:delete_chinese_comment
Open

[refactor](fe) Remove bilingual descriptions from variable annotations#66342
lsy3993 wants to merge 3 commits into
apache:masterfrom
lsy3993:delete_chinese_comment

Conversation

@lsy3993

@lsy3993 lsy3993 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: N/A

Problem Summary: Session and global variable annotations currently store both Chinese and English descriptions as a two-element array. The Chinese description is unused and the array shape makes callers cumbersome. This change keeps only the English description, updates the VarAttr annotation type, and adjusts the affected unit tests.

Release note

None

Check List (For Author)

  • Test: Unit Test
    • ./run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest
  • Behavior changed: No
  • Does this need documentation: No

### What problem does this PR solve?

Issue Number: N/A

Problem Summary: Session and global variable annotations currently store both Chinese and English descriptions as a two-element array. The Chinese description is unused and the array shape makes callers cumbersome. This change keeps only the English description, updates the VarAttr annotation type, and adjusts the affected unit tests.

### Release note

None

### Check List (For Author)

- Test: Unit Test
    - `./run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest`
- Behavior changed: No
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

lsy3993 and others added 2 commits July 31, 2026 23:12
### What problem does this PR solve?

Issue Number: N/A

Problem Summary: Config annotations currently store bilingual descriptions as a two-element array. The Chinese description is unused, and the array shape makes callers cumbersome. This change keeps only the English description, updates the ConfField annotation type, and adds a unit test asserting config descriptions do not contain Chinese.

### Release note

None

### Check List (For Author)

- Test: Unit Test
    - `./run-fe-ut.sh --run org.apache.doris.common.ConfigTest`
- Behavior changed: No
- Does this need documentation: No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants