chore(sql): remove deprecated DFParser constructors (Closes #23080 - partial)#23142
Merged
alamb merged 1 commit intoJun 24, 2026
Merged
Conversation
apache#23080 - partial) These constructors have been deprecated since 46.0.0 in favor of DFParserBuilder. A grep across the workspace confirms zero remaining callers, so we can safely delete them now that 55.x is in development (well past the 6-major-version grace period). AI assistance: Anthropic Claude (MiniMax-M3) on 2026-06-24 Generated-by: Anthropic Claude Signed-off-by: Dodothereal <129273127+Dodothereal@users.noreply.github.com>
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23080
Summary
Removes the deprecated
DFParser::newandDFParser::new_with_dialectconstructors fromdatafusion-sql. Both were deprecated since 46.0.0 in favor of theDFParserBuilderAPI, and a grep across the workspace confirms zero remaining callers (the only references are toDFParser::parse_sqlandDFParserBuilder::new, which we keep). With DataFusion now on 55.x, this clears the 6-major-version grace period for trivial removal.Test plan
git grep -nE 'DFParser::new\b|DFParser::new_with_dialect\b'returns no results in source or docs.datafusion-sqlpackage'sDFParserBuilderAPI surfaces (parse_sql,parse_sql_with_dialect) are unchanged and provide drop-in replacement ergonomics.AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently.
Signed-off-by: Dodothereal 129273127+Dodothereal@users.noreply.github.com