fix: Fix peak memory display in EXPLAIN ANALYZE for multiple operators#23140
Open
2010YOUY01 wants to merge 1 commit into
Open
fix: Fix peak memory display in EXPLAIN ANALYZE for multiple operators#231402010YOUY01 wants to merge 1 commit into
EXPLAIN ANALYZE for multiple operators#231402010YOUY01 wants to merge 1 commit into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Contributor
Author
It suggests to use Then downstream crate must include wildcard I think it's better to keep it as a breaking change and require downstreams to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See reproducer in
datafusion-cli:See
HashJoinExec: ... build_mem_used=2.80 B, it actually means 2.8 billion bytes, but it looks quite misleading. This PR fixes it:The reason is those metrics are tracking peak memory usage for a operator in the query lifecycle, so it's using
Gaugemetrics type, but how to choose display format become tricky (bytes or count?)This PR adds a new
Metrictype, that wraps the existingGauge, and use it to represent 'gauge for memory bytes', this fixes the bytes display issue.What changes are included in this PR?
MetricValue::PeakMemoryUsageto address the above issueAre these changes tested?
Are there any user-facing changes?