Quote value with leading or trailing Unicode whitespace#621
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printWithQuotesdecides MINIMAL-mode encapsulation from the first and last character, but only against ascii bounds:c <= Constants.COMMENTfor the leading char andisTrimChar(c <= ' ') for the trailing one. The parser'signoreSurroundingSpacesstrips anyCharacter.isWhitespaceon read, and several whitespace code points sit above' '(U+3000 ideographic space, U+2028/U+2029, U+2003, U+1680, U+205F, U+2000..U+200A). A value bounded by one of them, such asa, is written unquoted and read back trimmed toa. Quote when the first or last character isCharacter.isWhitespace, matching what the reader trims.isTrimCharis left alone since it is shared with thegetTrimpath that mirrorsString.trim.Found while round-tripping unicode whitespace through the printer with
ignoreSurroundingSpaces.mvn; that'smvnon the command line by itself.