Reject out-of-range values in LongLocaleConverter (1.X)#407
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
LongLocaleConverter.parse narrows the parsed number with longValue() and never range-checks it, so a value beyond long range like 99999999999999999999 is silently clamped to Long.MAX_VALUE instead of rejected: DecimalFormat returns it as a Double (the converter does not set parseBigDecimal) and Double.longValue() saturates. Add the same bounds check the sibling IntegerLocaleConverter, ByteLocaleConverter, ShortLocaleConverter and FloatLocaleConverter already apply before narrowing. Signed-off-by: Naveed Khan <dxbnaveed.k@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #406 to the
1.Xbranch.LongLocaleConverter.parsenarrows the parsed number withresult.longValue()and never range-checks it, so a value beyondlongrange like99999999999999999999is silently clamped toLong.MAX_VALUEinstead of rejected:DecimalFormatreturns it as aDouble(the converter does not setparseBigDecimal) andDouble.longValue()saturates.The sibling narrowing locale converters
IntegerLocaleConverter,ByteLocaleConverter,ShortLocaleConverterandFloatLocaleConverteralready reject out-of-range input, soLongLocaleConvertergets the same bounds check before narrowing. Found while auditing the locale converter family against those sibling checks.Added a regression test to
LongLocaleConverterTest; it fails without the runtime change (99999999999999999999comes back as9223372036854775807).mvn test -Dtest='*LocaleConverterTest'is green (107 tests).mvn; that'smvnon the command line by itself.