Skip to content

Add views for getting cumulative IC stats#1822

Merged
tuhaihe merged 2 commits into
apache:REL_2_STABLEfrom
MutableFire:gp_interconnect_stats_2
Jun 23, 2026
Merged

Add views for getting cumulative IC stats#1822
tuhaihe merged 2 commits into
apache:REL_2_STABLEfrom
MutableFire:gp_interconnect_stats_2

Conversation

@MutableFire

Copy link
Copy Markdown
Contributor
  • gp_interconnect_stats — aggregated statistics across all segments;
  • gp_interconnect_stats_per_segment — statistics grouped by segment;
  • gp_interconnect_stats_per_segment_per_host — statistics grouped by host and segment.

Based on the implementation from OpenGPDB (open-gpdb/gpdb#109).

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's REL_2 version of #1772

@tuhaihe

tuhaihe commented Jun 16, 2026

Copy link
Copy Markdown
Member

LGTM, it's REL_2 version of #1772

Any possibility will we cherry pick the commits from the main branch?

@MutableFire

MutableFire commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, it's REL_2 version of #1772

Any possibility will we cherry pick the commits from the main branch?

I've cherry-picked the commit from this REL_2 branch into the main branch. Everything looks correct and aligned with the changes from #1772. After this cherry-pick, I'll add the required fixes as well

@Smyatkin-Maxim Smyatkin-Maxim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix - force public schema. Otherwise I'm fine

Comment thread contrib/interconnect/interconnect.control
@MutableFire MutableFire force-pushed the gp_interconnect_stats_2 branch from 494fed8 to 423066f Compare June 18, 2026 09:19
@MutableFire MutableFire force-pushed the gp_interconnect_stats_2 branch from 423066f to f87dbfa Compare June 18, 2026 09:50
Comment thread contrib/interconnect/README.md Outdated
Comment thread contrib/interconnect/README.md Outdated

@my-ship-it my-ship-it left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tuhaihe

tuhaihe commented Jun 22, 2026

Copy link
Copy Markdown
Member

Hi @MutableFire we need some more fixes to support REL_2_STABLE branch. Thanks!

@MutableFire MutableFire force-pushed the gp_interconnect_stats_2 branch from f87dbfa to 0cbe920 Compare June 22, 2026 10:42
Comment thread contrib/interconnect/README.md Outdated
@MutableFire MutableFire force-pushed the gp_interconnect_stats_2 branch from 0cbe920 to 2b87a2d Compare June 22, 2026 10:48
@MutableFire MutableFire force-pushed the gp_interconnect_stats_2 branch from 360e2ad to 6707e7a Compare June 23, 2026 08:33
@MutableFire

Copy link
Copy Markdown
Contributor Author

Hi @MutableFire we need some more fixes to support REL_2_STABLE branch. Thanks!

Done.

@tuhaihe

tuhaihe commented Jun 23, 2026

Copy link
Copy Markdown
Member

Hi @MutableFire we need some more fixes to support REL_2_STABLE branch. Thanks!

Done.

Cool! All tests passed. Let me merge it.
Thanks again cc @MutableFire !

@tuhaihe tuhaihe merged commit 4c497f7 into apache:REL_2_STABLE Jun 23, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants