Conversation
julianhyde
reviewed
Sep 18, 2026
|
|
||
| /** Adds a relational expression to the stack, checking the | ||
| * {@link Config#emptyRowTypePolicy()}. */ | ||
| private void stackPush(RelNode rel, |
Contributor
There was a problem hiding this comment.
Changing every stack.push call site to stackPush seems fragile. Instead, could you change final Deque<Frame> stack to final Queue<Frame> stack, and assign to it an anonymous subclass of AbstractQueue<Frame> that checks for field-less RelNodes?
Member
Author
There was a problem hiding this comment.
Thank you for the suggestion, @julianhyde done in the latest commit.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-4597