fix out-of-bounds read parsing AVC SPS in ParseSPS#3371
Merged
Conversation
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
AVCDecoderConfigurationRecord::Createcopies the sequence header into a buffer that is not NUL-terminated (DEFINE_SMALL_ARRAY), then callsParseSPS(buf.data() + 2, sps_length).ParseSPStakes abutil::StringPiece, so the bareconst char*is turned into one through the implicitStringPiece(const char*)constructor, which runsstrlen. When a publisher sends an AVC sequence header whose SPS body has no zero byte, thatstrlenwalks off the end of the copied record and reads out of bounds. The path is reachable from untrusted RTMP video input.What is changed and the side effects?
Changed:
Pass
buf.substr(2, sps_length)soParseSPSreceives an explicitly sized view and nostrlenruns. It is the same idiom already used a few lines below when pushing intosps_list. I also added a regression test that feeds a zero-free SPS body, which trips ASan on the old code and stays clean after the fix.Side effects:
Performance effects: none.
Breaking backward compatibility: none. The reads inside
ParseSPSwere already bounded bysps_length, so valid sequence headers parse exactly as before.Check List: