GH-477: Fix Flight JDBC DATE(MILLISECOND) parameter binding#1219
Open
yujin5701 wants to merge 1 commit into
Open
GH-477: Fix Flight JDBC DATE(MILLISECOND) parameter binding#1219yujin5701 wants to merge 1 commit into
yujin5701 wants to merge 1 commit into
Conversation
yujin5701
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
This fixes Flight JDBC prepared statement binding for Arrow
DATE(MILLISECOND)parameters.
Avatica represents JDBC
DATEvalues as days since the Unix epoch. The FlightJDBC parameter binder already writes that value correctly for
DateDayVector,but it was also writing the same day value directly into
DateMilliVector,which expects milliseconds since the Unix epoch.
This now converts epoch days to epoch milliseconds before writing to
DateMilliVector.Tested with
ArrowFlightPreparedStatementTest.Closes #477.