Avoid consuming one-shot helper iterables - #1838
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent SDK helper telemetry from consuming one-shot
Iterablerequest parameters before they are serialized.The Messages APIs accept
Iterablevalues formessagesandtools.stainless_helper_header()currently iterates both collections to discover helper tags before request-body transformation runs. When a caller supplies a generator, telemetry exhausts it first, so the actual request can lose its messages or tools entirely.Fix
Restrict helper-tag collection to safely replayable
Sequenceinputs. Lists, tuples, and other replayable sequences continue to contribute helper telemetry. Arbitrary iterables such as generators are left untouched so request serialization remains the first consumer.Regression coverage
Adds tests verifying that generator-backed
messagesandtoolssurvive into the actual JSON request body, while normal list-backed helper telemetry continues to work.The production change is confined to Anthropic's hand-maintained
_stainless_helpers.pypath.