Skip to content

fix(streaming): resolve unchecked content block index and type safety issues #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vjaudir8123-debug wants to merge 1 commit into from
+16 −14
Closed

fix(streaming): resolve unchecked content block index and type safety issues #1797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/anthropic/lib/streaming/_beta_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,18 +469,18 @@ def accumulate_event(
if current_snapshot is None:
if event.type == "message_start":
return cast(
ParsedBetaMessage[ResponseFormatT], ParsedBetaMessage.construct(**cast(Any, event.message.to_dict()))
ParsedBetaMessage[ResponseFormatT],
construct_type(type_=ParsedBetaMessage, value=event.message.to_dict()),
)

raise RuntimeError(f'Unexpected event order, got {event.type} before "message_start"')

if event.type == "content_block_start":
# TODO: check index
current_snapshot.content.append(
cast(
Any, # Pydantic does not support generic unions at runtime
construct_type(type_=ParsedBetaContentBlock, value=event.content_block.to_dict()),
),
while len(current_snapshot.content) <= event.index:
current_snapshot.content.append(None) # type: ignore[arg-type]
current_snapshot.content[event.index] = cast(
Any, # Pydantic does not support generic unions at runtime
construct_type(type_=ParsedBetaContentBlock, value=event.content_block.to_dict()),
)
if event.content_block.type == "fallback":
# the final hop's fallback block names the model that served the response —
Expand Down
16 changes: 9 additions & 7 deletions src/anthropic/lib/streaming/_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,17 +449,19 @@ def accumulate_event(

if current_snapshot is None:
if event.type == "message_start":
return cast(ParsedMessage[ResponseFormatT], ParsedMessage.construct(**cast(Any, event.message.to_dict())))
return cast(
ParsedMessage[ResponseFormatT],
construct_type(type_=ParsedMessage, value=event.message.to_dict()),
)

raise RuntimeError(f'Unexpected event order, got {event.type} before "message_start"')

if event.type == "content_block_start":
# TODO: check index
current_snapshot.content.append(
cast(
Any, # Pydantic does not support generic unions at runtime
construct_type(type_=ParsedContentBlock, value=event.content_block.model_dump()),
),
while len(current_snapshot.content) <= event.index:
current_snapshot.content.append(None) # type: ignore[arg-type]
current_snapshot.content[event.index] = cast(
Any, # Pydantic does not support generic unions at runtime
construct_type(type_=ParsedContentBlock, value=event.content_block.model_dump()),
)
elif event.type == "content_block_delta":
content = current_snapshot.content[event.index]
Expand Down