fix(drive): reject ambient fixture config - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Drive places isolated projects under
TMPDIR. If that directory has an ancestor.opencode,.claude,.agents, or direct OpenCode config, V2 intentionally discovers it and silently injects ambient skills, plugins, and instructions into the fixture (#84).What Changes
Before creating an instance, Drive now scans the artifact-root ancestry for OpenCode configuration sources. It refuses contaminated roots with the exact source path and tells the caller to use a neutral
TMPDIR, preventing a test or recording from silently using host configuration.Isolation boundary
The generated project's own
.opencodedirectory remains the fixture-owned configuration source. Only ancestors outside the generated artifact root are rejected.Scope
This does not change OpenCode's intentional upward discovery behavior or Drive's artifact layout. It makes the existing isolation contract fail closed when the selected temporary ancestry cannot satisfy it.
Verification
ambientskill; the fixed build refuses that same root before launch and names the ancestor.opencodedirectory.