fix(drive): stop manual server scripts - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A manual script can intentionally launch only an isolated server and remain active for an external client. Even after that server is ready, Drive leaves the instance manifest in
starting, sostop --namerejects it and the owner process must be terminated manually (#88).What Changes
Treat a successful manual
server.launch()as a script readiness boundary, just liketuis.launch(). Server-only scripts become inspectable and stoppable while their run Effect remains active; scripts that have launched neither a server nor a TUI remain protected as genuinely starting.Scope
This only changes readiness publication for manual scripts. Server lifetime, control-socket ownership, automatic scripts, and TUI readiness are unchanged.
Verification
Effect.neverfixture that becomes ready and shuts down throughstop --name.