Skip to content

fix(cdk/testing): use directive fixture onDestroy #33793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crisbeto merged 1 commit into from
Sep 10, 2026
Merged

fix(cdk/testing): use directive fixture onDestroy #33793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/cdk/testing/testbed/testbed-harness-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@ import {
stopHandlingAutoChangeDetectionStatus,
TestElement,
} from '../../testing';
import {ComponentFixture, DirectiveFixture, flush, TestBed} from '@angular/core/testing';
import {ComponentFixture, DirectiveFixture, flush} from '@angular/core/testing';
import {Observable} from 'rxjs';
import {takeWhile} from 'rxjs/operators';
import {TaskState, TaskStateZoneInterceptor} from './task-state-zone-interceptor';
import {UnitTestElement} from './unit-test-element';
import {DestroyRef} from '@angular/core';

/** Options to configure the environment. */
export interface TestbedHarnessEnvironmentOptions {
Expand Down Expand Up @@ -124,8 +123,7 @@ export class TestbedHarnessEnvironment extends HarnessEnvironment<Element> {
if (_fixture instanceof ComponentFixture) {
_fixture.componentRef.onDestroy(onDestroy);
} else {
// TODO(crisbeto): use host ref in directive fixture once it's available.
TestBed.inject(DestroyRef).onDestroy(onDestroy);
_fixture.onDestroy(onDestroy);
}
}

Expand Down
Loading