Fix(cdk/overlay): vertical positioning of flexible connected overlay on mobile - #28425
Fix(cdk/overlay): vertical positioning of flexible connected overlay on mobile#28425ShukinDmitriy wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi! I’ve rebased and refreshed this PR against the current The previous scrollbar-based implementation has been replaced with a The CDK overlay unit suite passes in both Chromium and Firefox. This is ready |
Fixes #13614.
Summary
Flexible connected overlays using
overlayY: 'bottom'calculated their positionrelative to
documentElement.clientHeight, even when their actual containingblock was the overlay container with different dimensions.
This change calculates the bottom offset relative to the overlay container for
regular overlays. Native popovers continue to use the viewport because they are
rendered in the top layer and have a different containing block.
The fix does not measure scrollbars or create temporary DOM elements in the
reposition path.
Testing
Added regression coverage for:
updatePosition();The CDK overlay unit suite passes in Chromium and Firefox.