Standardize container instructions on the docker command (podman-docker) - #768
Draft
adamlam2-amd wants to merge 3 commits into
Draft
adamlam2-amd wants to merge 3 commits into
adamlam2-amd wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playbooks previously mixed podman and docker commands, which caused friction for users who had one engine but not the other (surfaced by a user hitting podman-specific steps in the Hermes playbook).
Approach: all container instructions now use the docker command, which works with either real Docker or podman-docker (a wrapper that provides a docker-compatible CLI backed by the Podman engine, available in the Ubuntu repos). This means users need one of: Docker (if already installed), or podman-docker (which pulls in the Podman engine automatically). podman-docker is already preinstalled on HaloBox Linux.
Changes:
Intentionally unchanged:
Requires:
Known follow-up (not in this PR):