Use procfs for CPU and process collection - #292
Open
salemmoustafa wants to merge 3 commits into
Open
salemmoustafa wants to merge 3 commits into
salemmoustafa wants to merge 3 commits into
Conversation
github-actions
Bot
added
documentation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Four unresolved moderate issues remain in procfs process collection.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
Ports process collection from rocm-smi/top to /proc, removing KFD analysis and updating configuration, tests, and documentation.
Changes:
- Adds procfs-based CPU and process sampling.
- Removes KFD fields, limits, and obsolete configuration.
- Updates tests, fixtures, and plugin documentation.
| File | Changes and review notes |
|---|---|
test/unit/plugin/test_process_collector.py |
Updates procfs collection and parsing tests. |
test/unit/plugin/test_process_analyzer.py |
Updates analyzer tests. |
test/unit/plugin/test_analyzer_args_build_from_model.py |
Updates argument construction tests. |
test/functional/fixtures/process_plugin_config.json |
Removes obsolete KFD configuration. |
nodescraper/plugins/inband/process/processdata.py |
Removes KFD data from the process model. |
nodescraper/plugins/inband/process/process_collector.py |
Implements procfs collection. Four unresolved moderate issues remain: robustly parse names containing parentheses, rank only currently running processes, exclude guest CPU fields from totals, and apply the PID fallback when name lookup returns an empty value. |
nodescraper/plugins/inband/process/process_analyzer.py |
Analyzes aggregate CPU usage without KFD data. |
nodescraper/plugins/inband/process/collector_args.py |
Adds sampling interval configuration. |
nodescraper/plugins/inband/process/analyzer_args.py |
Removes the KFD limit argument. |
docs/PLUGIN_DOC.md |
Documents the new procfs behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
salemmoustafa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the ProcessPlugin's
topandrocm-smicollection with distro-independent/procsampling. Removes KFD process analysis and updates configuration, tests, and documentation.Test plan
pytest test/unitpytest test/functional(if applicable) — focused ProcessPlugin test passed locally; full suite passed in CIpre-commit run --all-filesChecklist