Semantic notification icons: thermometer + state-aware status (#34)#41
Merged
Conversation
The temperature alert and the persistent status notification reused the "battery charging" glyphs as placeholders, so a heat alert showed a charging icon and the ongoing notification could show a charging bolt while discharging. Add a small monochrome (white-on-transparent) vector icon set and wire it up: - ic_stat_temperature_hot — thermometer for the high-temperature alert. - ic_stat_battery_full / _low / _charging — the ongoing status icon now shows a bolt only while actively charging, otherwise a plain battery whose fill reflects the level (a charged-but-plugged battery reads as full, no bolt). The pre-existing critical/warning/full alert icons are left as-is (out of scope per the issue). The old charging PNG glyphs remain in use there. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34. Cosmetic polish from #5 (persistent notification) and #18 (temperature alert), which reused the "battery charging" glyphs as placeholders.
Problem
ic_stat_device_battery_charging_20— a charging icon for a heat alert.Change
Added a small monochrome, white-on-transparent vector icon set (status-bar icons render as an alpha mask):
ic_stat_temperature_hot— thermometer, for the high-temperature alert.ic_stat_battery_full/ic_stat_battery_low/ic_stat_battery_charging— the ongoing status icon now shows a bolt only while actively charging, otherwise a plain battery whose fill reflects the level. A charged-but-still-plugged battery (BATTERY_STATUS_FULL) reads as a full battery, no bolt.The pre-existing critical/warning/full alert icons are intentionally left as-is (out of scope per the issue); the old charging PNGs remain in use there.
Acceptance criteria
Testing
./gradlew :app:assembleDebug— vectors compile, build passes. A rendered preview of the four icons is attached in the PR discussion / was shared for review. Not device-verified — worth a glance in the real status bar (small-icon masking) on a device.🤖 Generated with Claude Code