Debug menu: read-only info in release, gate mutating actions (#30)#40
Merged
Conversation
#21 hid the entire battery-health debug menu behind debuggable builds. The read-only "Show Debug Info" dump is harmless and useful for diagnosing user reports, so keep it available in release; only the data-mutating actions need to stay debug-only. - The long-press entry point is always registered. - In release builds it surfaces only the read-only tracking dump. - In debuggable builds it shows the full menu (add/reset cycles). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30. Stacked on #29 (
feature/29-debug-reset-scope) — retarget tomasteronce #39 merges. Follow-up from the debug-menu review (#14 / #21).Change
#21 gated the entire battery-health debug menu (long-press on the health %) behind debuggable builds. The read-only "Show Debug Info" dump is harmless and useful for diagnosing user reports, so split the menu into two tiers:
The long-press entry point stays unobtrusive so normal users won't stumble into it, and no data-mutating action is reachable in release.
Acceptance criteria
Testing
./gradlew :app:assembleDebugpasses. Release gating is a build-config branch (FLAG_DEBUGGABLE); not device-verified.🤖 Generated with Claude Code