feat(picker): support negative default_index - #166
Open
miskatul-anwar wants to merge 1 commit into
Open
Conversation
Owner
|
Why the try/except around cadule? It's already declared in pyproject.toml, so if it's missing the install is already broken, and this just turns a clear ImportError into a confusing TypeError later on. Also this PR is doing too many unrelated things at once. Please split it up, one PR per feature. |
miskatul-anwar
force-pushed
the
feat/negative-index-select-all-and-disabled-fix
branch
from
August 23, 2026 18:51
4e6190d to
86676b7
Compare
Author
|
Thanks for the review @aisk! I've addressed both points:
I will open separate PRs for the disabled option safety fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for negative
default_indexvalues (e.g.default_index=-1to select the last option by default), following standard Python negative indexing conventions.-len(options) <= default_index < len(options).tests/test_pick.py.Testing