American spelling in comments and test names - #131
Merged
Merged
Conversation
One comment in the identity policy spelled it the British way; the org rule is American spelling in prose and code alike. Comment only, so nothing published changes and no release is cut for it.
Comments and test names only (recognize, honors); the receipt's fulfillment status values stay as the wire contract spells them. Nothing published changes and no release is cut for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
American spelling in comments and test names (recognize, honors), from a workspace-wide sweep for British forms. The receipt's fulfillment status values stay as the wire contract spells them. Nothing published changes and no release is cut for it.
Worked with: Varun.
Type of change
Public API
none
Test plan
bun run lint,bun run typecheck,bun run testlocally.Checklist