feat(runtime): add Kagent deployment and discovery adapter by xytian315 · Pull Request #655 · agentregistry-dev/agentregistry

xytian315 · 2026-08-27T20:20:34Z

Description

Add a built-in Kagent runtime adapter for deployment and discovery.

Deploy and remove prebuilt A2A BYO Agents through Kagent.
Deploy and remove remote and source-backed MCPServers through Kagent.
Resolve Agent model and MCPServer references when building Kagent workloads.
Discover Kagent Agents and MCPServers and correlate them with managed deployments.
Support per-runtime authentication through Secret references.
Register Kagent deployment and discovery support by default.

Change Type

/kind feature

Changelog

Added Kagent runtime support for deploying BYO Agents and MCPServers and discovering Kagent workloads.

Additional Notes

Targeted development and smoke testing use Kagent v0.10.0-rc3.

Agent deployment currently supports prebuilt A2A workloads defined with spec.source.image. Harness-based deployments and Agents without a prebuilt image are not supported.

Manual smoke coverage included BYO Agent deployment, remote MCPServer deployment, and out-of-band Agent discovery.

Copilot

Pull request overview

Adds a first-party Kagent runtime integration to AgentRegistry, covering workload translation, apply/remove behavior, REST client wiring, and discovery so Kagent-managed Agents/MCPServers can be deployed and correlated back to AgentRegistry Deployments.

Changes:

Introduces a new pkg/runtimes/kagent adapter with translation logic (BYO Agents + MCPServer tool servers), REST client, status handling, desired fingerprinting, and discovery.
Registers Kagent as a known runtime type and hooks runtime config validation into Runtime.Validate().
Wires Kagent into the registry app defaults and adds a DB-backed Deployment finder used to resolve source-backed MCPServer dependencies.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/runtimes/kagent/translate.go	Translates AgentRegistry resources into Kagent REST payloads; resolves model + MCP wiring.
pkg/runtimes/kagent/translate_test.go	Unit tests for translation, model resolution, and MCP dependency wiring.
pkg/runtimes/kagent/status.go	Maps translation/apply outcomes into AgentRegistry ApplyResult conditions + runtime metadata.
pkg/runtimes/kagent/status_test.go	Tests condition builders for success/failure/removal.
pkg/runtimes/kagent/rest_types.go	Defines private Kagent REST wire payload structs/constants.
pkg/runtimes/kagent/fake_client_test.go	Fake Kagent client used by adapter/discovery tests.
pkg/runtimes/kagent/discover.go	Implements runtime discovery for Agents and MCPServers from Kagent.
pkg/runtimes/kagent/discover_test.go	Tests discovery behavior, namespace filtering, and real ID response shape.
pkg/runtimes/kagent/config.go	Runtime/deploy config decoding + admission-time validation helpers.
pkg/runtimes/kagent/config_test.go	Tests config decoding/validation and admission registration behavior.
pkg/runtimes/kagent/client.go	REST client for Kagent API (create/update/delete/list).
pkg/runtimes/kagent/client_test.go	Tests REST client request/response behavior and replacement flows.
pkg/runtimes/kagent/adapter.go	Main adapter: Apply/Remove/Discover/DesiredFingerprint + auth token sourcing.
pkg/runtimes/kagent/adapter_test.go	Adapter tests for apply/remove, metadata, labels, fingerprint behavior, and auth resolution.
pkg/api/v1alpha1/runtime_validate.go	Adds `RuntimeConfigValidators` and invokes per-runtime config validators during `Runtime.Validate()`.
internal/registry/registry_app.go	Registers Kagent adapter/discovery source by default and wires Deployment finder + optional secret resolver.
internal/registry/database/resolvers.go	Adds DB-backed `NewKagentDeploymentFinder` used to locate managed deployments for MCP dependencies.
internal/registry/database/resolvers_integration_test.go	Integration test for the Kagent deployment finder SQL filtering/matching.
internal/cli/common/deployments.go	Improves CLI DeploymentStatus derivation for Ready=false failures.
internal/cli/common/deployments_test.go	Adds coverage for Ready=false/Failed mapping to “failed”.
Makefile	Updates Kagent version and Helm install flags for the newer chart layout.

Suppressed comments (1)

pkg/runtimes/kagent/config.go:213

decodeDeployConfig guards secretRefs by checking only the exact map key "secretRefs". Since JSON unmarshal is case-insensitive, a user could specify "SecretRefs" and have it populate cfg.SecretRefs without triggering the kind check, allowing unsupported deploy config fields to slip through validation for non-MCPServer targets.

func decodeDeployConfig(m map[string]any, targetKind string) (deployConfig, error) {
	if _, found := m["secretRefs"]; found && targetKind != v1alpha1.KindMCPServer {
		return deployConfig{}, fmt.Errorf("secretRefs is only supported for MCPServer deployments")
	}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

NewStoreDeploymentFinder takes a Deployment store directly; the generic database package no longer carries Kagent-specific lookup code.

Exports ErrAuthExpired, ErrDependencyNotReady, and FailedApplyResult; adds finder coverage for namespace mismatches.

timflannagan

As always, thanks for running this work down Kristy. One generic question that was hard to capture as an inline review comments. How much of this code can be moved into internal vs. exposed via pkg/? I think some of that will inform whether pkg/runtimes/kagent is a net new package we should introduce here vs. follow existing patterns in the codebase.

timflannagan · 2026-08-31T21:51:21Z

+	if ready := dep.Status.GetCondition("Ready"); ready != nil {
+		if ready.Status == v1alpha1.ConditionTrue {
+			return "deployed"
+		}
+		if ready.Status == v1alpha1.ConditionFalse && ready.Reason == "Failed" {
+			return "failed"
+		}


Let's update pkg/status and use the existing constants or expand it

thanks! changed here 67d030b

timflannagan · 2026-08-31T21:54:56Z

I'll highlight this here instead of where it's defined. My preference is adding another method on the DeploymentController that was refactored recently. Ex: DeploymentApplied, instead of maintaining another separate type definition and introducing more indirection.

thanks! changed here 67d030b

timflannagan · 2026-08-31T21:55:18Z

How much of this testing could be reduced to a single table-driven test?

thanks! changed here 67d030b

timflannagan · 2026-08-31T21:56:00Z

+// RuntimeConfigValidators lets runtime packages register admission checks
+// without coupling the API package to concrete adapter implementations.
+var RuntimeConfigValidators = map[string]func(map[string]any) error{}


Fine for now, but this comment suggests a smell with our admission/validation logic

timflannagan · 2026-08-31T21:56:48Z

+var _ types.DeploymentAdapter = (*adapter)(nil)
+var _ types.DeploymentDiscoverySource = (*adapter)(nil)
+var _ types.DeploymentDesiredFingerprinter = (*adapter)(nil)


Same thing as above, fine for now, having to satisfy these many interfaces is a clear smell in our abstractions to me.

timflannagan · 2026-08-31T22:29:13Z

+			Name:       w.Name,
+			RuntimeMetadata: map[string]string{
+				types.RuntimeMetadataRemoteIDKey: w.Name,
+				"namespace":                      w.Namespace,


Should we add a constant for this?

thanks changed here 67d030b

timflannagan · 2026-08-31T22:37:58Z

+}
+
+// WithWorkloadLabels adds labels to pod-backed Kagent resources.
+func WithWorkloadLabels(labels map[string]string) Option {


Surprised we need this type of wiring. Can't this be derived from runtime or deployment config? Or even hardcoded via code?

thanks! moved to runtimeDeploymentConfig in this commit 67d030b

timflannagan · 2026-08-31T22:38:55Z

+	if !ok || input.Deployment == nil {
+		return types.DefaultApplyFingerprint(ctx, input, options)
+	}
+	hasMCPDependencies := len(agent.Spec.MCPServers) > 0 ||


While we're at it, we should talk about this spec.deploymentRefs field and the future of whether it's still beneficial here.

Yeah want to talk about this more. The assumption going forward is that every adapter will need to implement if it it's in the API surface. This PR just highlights this logic and not something and not a blocker for merging. The issue is I now have N ways to source an MCP server via the Agents API.

timflannagan · 2026-08-31T23:04:01Z

+
+const (
+	kagentV1Alpha2APIVersion        = "kagent.dev/v1alpha2"
+	kagentV1Alpha1APIVersion        = "kagent.dev/v1alpha1"


I'd almost be in favor of dropping this tbh. Our approach is best effort anyways.

thanks! removed in this commit 67d030b

# Conflicts: # internal/cli/common/deployments_test.go

xytian315 added 2 commits August 27, 2026 12:38

feat(kagent): add deployment and discovery adapter

e6531fc

chore(kagent): satisfy lint checks

285cca6

Copilot AI lite review requested due to automatic review settings August 27, 2026 20:20

github-actions Bot added kind/feature release-note labels Aug 27, 2026

Copilot started reviewing on behalf of xytian315 August 27, 2026 20:21 View session

Copilot AI reviewed Aug 27, 2026

View reviewed changes

Comment thread pkg/runtimes/kagent/config.go

xytian315 added 2 commits August 27, 2026 13:37

fix(kagent): reject case-variant secret fields

24fc8f6

feat: add deployment apply observation hook

f9184d6

xytian315 force-pushed the xytian315/oss-kagent branch from 4bbebb6 to fad7df7 Compare August 28, 2026 06:44

xytian315 added 2 commits August 27, 2026 23:45

refactor(kagent): move deployment finder into the kagent package

ab06d75

NewStoreDeploymentFinder takes a Deployment store directly; the generic database package no longer carries Kagent-specific lookup code.

feat(kagent): export apply failure helpers

9e30614

Exports ErrAuthExpired, ErrDependencyNotReady, and FailedApplyResult; adds finder coverage for namespace mismatches.

xytian315 force-pushed the xytian315/oss-kagent branch from fad7df7 to 9e30614 Compare August 28, 2026 06:45

xytian315 added 3 commits August 28, 2026 00:05

fix(kagent): honor deprecated agent model fields without a modelRef

186d495

feat(kagent): export RuntimeNamespace

c467a6d

fix(kagent): return the persisted failure from Logs instead of an error

81d0447

xytian315 requested review from ilackarms, shashankram and timflannagan August 28, 2026 17:49

timflannagan reviewed Aug 31, 2026

View reviewed changes

xytian315 added 5 commits August 31, 2026 19:50

Merge remote-tracking branch 'origin/main' into xytian315/oss-kagent

c603335

refactor(kagent): simplify adapter integration

67d030b

Merge remote-tracking branch 'origin/main' into xytian315/oss-kagent

5e63d8e

# Conflicts: # internal/cli/common/deployments_test.go

refactor(kagent): remove unused global token option

5c014f6

fix(kagent): persist canonical runtime metadata

3fb03d9

Uh oh!

Conversation

xytian315 commented Aug 27, 2026

Description

Change Type

Changelog

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

timflannagan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants