fix(atenet): add router health hysteresis - #700
Open
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Open
fix(atenet): add router health hysteresis#700NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Conversation
NekoPunch (orangeCatDeveloper)
force-pushed
the
health-hysteresis
branch
4 times, most recently
from
August 6, 2026 17:02
a7808f1 to
611b834
Compare
NekoPunch (orangeCatDeveloper)
force-pushed
the
health-hysteresis
branch
9 times, most recently
from
August 18, 2026 01:59
42d66bb to
f568d02
Compare
NekoPunch (orangeCatDeveloper)
force-pushed
the
health-hysteresis
branch
5 times, most recently
from
August 25, 2026 03:32
9bceb18 to
3859f13
Compare
NekoPunch (orangeCatDeveloper)
changed the title
NekoPunch (orangeCatDeveloper)
force-pushed
the
health-hysteresis
branch
2 times, most recently
from
August 27, 2026 07:09
2e52ad6 to
0bb5521
Compare
A transient probe failure made statusz unhealthy for one interval and paged monitoring. Require three consecutive failures, while one success restores health and resets the streak. Continue updating diagnostics on every probe so flaps remain visible.
NekoPunch (orangeCatDeveloper)
force-pushed
the
health-hysteresis
branch
from
August 29, 2026 19:06
0bb5521 to
5137b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #616
Summary
updateComponentHealthsetHealthydirectly from each probe result, so a single 500ms blip to Envoy's admin port or the Kubernetes API flipped/statuszunhealthy for one polling interval and paged any monitoring built on it. A component now flips unhealthy only after 3 consecutive probe failures; a single success restores it and resets the streak. A component that has never succeeded stays unhealthy (zero value), andmessage/last_failure/failure_countstill update on every probe, so individual flaps remain observable — only thehealthyboolean gains hysteresis. The health check is observability-only, so no traffic behavior changes.Test plan
Unit: threshold enforcement, streak reset on recovery, never-healthy zero-value boundary; plus an integration-style test driving
rh.check()with a flapping Envoy probe and asserting/statuszholds healthy through 2 transient failures, flips on the 3rd, and recovers on success. Package tests pass with-race.kind cluster: deployed the router with this change and ran the e2e suites — demo, example, identity, networking, networkpolicy, and parking pass. The metrics suite fails identically on a clean-main deployment (pre-existing router-metrics-export issue), confirmed by control experiment.
Tests pass
Appropriate changes to documentation are included in the PR (none needed)