ateapi: fail cleanly on a malformed actor JWT signing pool - #601
Closed
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Closed
ateapi: fail cleanly on a malformed actor JWT signing pool#601Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Conversation
Mesut Oezdil (mesutoezdil)
changed the title
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/session-jwt-pool-panics
branch
4 times, most recently
from
August 28, 2026 20:01
55cb184 to
8cde094
Compare
Collaborator
|
Apologies, I think this may be superseded by #1313 |
MintJWT indexes Authorities[0] from the actor JWT signing pool file, and actoridjwt.Sign type-asserts the signing key without checking it, so a pool file carrying no authorities (which localjwtauthority. Unmarshal accepts without error) or an algorithm that does not match its key panics instead of returning an error. Nothing in the server installs a panic-recovery interceptor, so that configuration error takes down ate-api-server on the first MintJWT call, and MintCert already guards the same situation for its own pool. Adds the missing checks plus the first tests for both packages, which also pin the behavior of the paths that already worked.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/session-jwt-pool-panics
branch
from
August 29, 2026 08:38
8cde094 to
77c9995
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MintJWTindexesAuthorities[0]from the actor JWT signing pool file, andactoridjwt.Signtype-asserts the signing key without checking it, so a pool file carrying no authorities (whichlocaljwtauthority.Unmarshalaccepts without error) or an algorithm that does not match its key panics instead of returning an error. Nothing in the server installs a panic-recovery interceptor, so that configuration error takes down ate-api-server on the firstMintJWTcall, andMintCertalready guards the same situation for its own pool. This adds the missing checks plus the first tests for both packages, which also pin the behavior of the paths that already worked.