hack: wait for a pool's Deployment to exist before its rollout [CI flake fix] - #1320
Open
Benjamin Elder (BenTheElder) wants to merge 1 commit into
Open
Conversation
ate-controller creates a WorkerPool's Deployment, so it does not exist yet when the apply returns. `kubectl rollout status` reads the object before it starts watching and errors on a missing one instead of waiting, so whether these waits worked at all came down to beating the controller by a round trip. e2e lost that race by 178ms, failing the deploy with NotFound while the pool's pods were already being created.
Benjamin Elder (BenTheElder)
added
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ate-controller creates a WorkerPool's Deployment, so it does not exist yet when the apply returns.
kubectl rollout statusreads the object before it starts watching and errors on a missing one instead of waiting, so whether these waits worked at all came down to beating the controller by a round trip.e2e lost that race by 178ms, failing the deploy with NotFound while the pool's pods were already being created.
Fixes yet another flake I observed here: https://github.com/agent-substrate/substrate/actions/runs/33275880827/job/99162382080?pr=1283