Replace actor template namespace/name pair with ActorTemplate substrate ObjectRef in internal protos - #1304
Open
Zoe Zhao (zoez7) wants to merge 1 commit into
Open
Conversation
Zoe Zhao (zoez7)
requested review from
Tim Bai (baizhenyu),
Da Huang (git286) and
Krisztian F (krisztianfekete)
August 28, 2026 23:01
Zoe Zhao (zoez7)
force-pushed
the
actor-template-objectref
branch
from
August 28, 2026 23:52
8435847 to
71b19ba
Compare
…te ObjectRef in internal protos
Zoe Zhao (zoez7)
force-pushed
the
actor-template-objectref
branch
from
August 29, 2026 00:50
71b19ba to
dfe7e8c
Compare
|
|
||
| message TerminateWorkloadRequest { | ||
| reserved 4, 5; | ||
| reserved "actor_template_namespace", "actor_template_name"; |
Collaborator
There was a problem hiding this comment.
Don't reserve fields. Just drop them and reuse the IDs. We are breaking the API anyways.
|
|
||
| // ObjectRef references a Substrate resource by its (atespace, name) identity. | ||
| // Mirrors ateapipb.ObjectRef, which internal protos do not import. | ||
| message ObjectRef { |
Collaborator
There was a problem hiding this comment.
ObjectRef is a concept of the control plane API (mgmt plane) where we need a way for resources to reference another resources. We could introduce the same concept in the atelet API (control plane), although I'm not sure how useful that is.
If we adopt it, we should use it consistently, for example, we have atespace, actor_name , which could be an ObjectRef too, but for actors we also have an actor_uid which isn't in the ObjectRef (I guess that could be a separate top level field alongside actor ?
ObjectRef actor;
string actor_uid;
ObjectReg actor_template;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Atelet and Ateom internal APIs consume actor template namespace/name pair to telemetry. Updated them to use the new Substrate ActorTemplate proto instead of the legacy CRD one.