Declarative validation for ActorTemplate - #1303
Open
shrutiyam-glitch wants to merge 14 commits into
Open
Conversation
shrutiyam-glitch
requested review from
Julian Gutierrez Oschmann (juli4n) and
Zoe Zhao (zoez7)
August 28, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the declarative-validation (DV) migration from #1215, covering the
ActorTemplateresource, its full spec tree, the create path, and read/delete verbs.Key Changes
ActorTemplatespec (Metadata,SandboxConfig,SnapshotsConfig,Container,Volume,Resources).CreateActorTemplate. Custom rules (e.g.,on_commit ⊆ on_pause) are now handled via custom hooks.Get,List, andDeleterequests to use DV.atepgmetadata setters to update in-place.Deliberate Behavior Changes
The gRPC path now strictly enforces CRD rules. Specific tightenings include:
worker_selectoris now rejected.EnvVar.nameis strictly required.minimum=1).page_tokenis capped at 256 characters (matching other list requests).Deliberately Not Done
ActorTemplatesare immutable to clients. The reconciler updates the status directly against the store, so tagging the status subtree or adding update validation isn't necessary right now.config_namematchingsandbox_class: Enforcing this requires calling SandboxConfigLister (ServiceImpl), so it's left as a TODO.Testing
TestCreateActorTemplate*,TestUpdateActorTemplateMetadata, and theatepgsuite) verified against real Postgres via testcontainers.