Extend declarative validation to ActorSnapshotTags - #1260
Open
shrutiyam-glitch wants to merge 9 commits into
Open
Extend declarative validation to ActorSnapshotTags#1260shrutiyam-glitch wants to merge 9 commits into
shrutiyam-glitch wants to merge 9 commits into
Conversation
shrutiyam-glitch
requested review from
Julian Gutierrez Oschmann (juli4n) and
Tim Hockin (thockin)
August 28, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on issue #1168 and the base PR #1215
Schema (
ateapi.proto)ActorSnapshotTag: Added DV tags (atespaced metadata, immutable snapshot, and min/max scope bounds).opaqueTypewith custom validation).ActorSnapshotresource remains fenced out of scope for a future server-written-state migration.Service & Storage Layers
atepg.go) to the service layer (actor_snapshot.go) via a validate-in-closure pattern on Update.CreateActorSnapshotTagnow properly scrubs server-assigned metadata and enforces that a tag must live in its snapshot's Atespace.Notes
ListActorSnapshotsRequest.page_tokenis now capped at 256 characters.INVALID_ARGUMENTas anInvalidtype rather thanNotSupported.uid/versionpresence checks moved to the store's precondition check.Testing
Added comprehensive tests covering all tagged fields, List pagination, immutability guarantees, cross-atespace rejections, server-metadata scrubs, and end-to-end RPC workflows.