Record a CLI run in history after the LAVA file is written - #233
Merged
Merged
Conversation
record_recent_run returns early when the .lava file is not on disk. The CLI called it inside crunch_artifacts, which runs before lava_finalize_output writes that file, so no CLI run was ever recorded. GUI runs were recorded, because vleappGUI.py already does it in the right order. Capture the crunch result, record after finalize, and gate on success, matching the GUI. Measured with an isolated HOME on a real run: 0 runs recorded before, 1 after. Found by James Habben in abrignoni/iLEAPP#2232. Co-Authored-By: James Habben <6327329+JamesHabben@users.noreply.github.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records a CLI run in the recent-run history after the LAVA file exists.
record_recent_runreturns early when the.lavafile is not on disk. The CLI called it insidecrunch_artifacts, which runs beforelava_finalize_outputwrites that file, so no CLI run was ever recorded. GUI runs were recorded, becausevleappGUI.pyalready does it in the right order.Captures the crunch result, records after finalize, and gates on success, matching the GUI.
Measured with an isolated HOME on a real run: 0 runs recorded before, 1 after.
Found by @JamesHabben in abrignoni/iLEAPP#2232.
🤖 Generated with Claude Code