Read NTFS and APFS images in one pass, with qnxprobe 1.30 - #219
Merged
Merged
Conversation
The raw image seeker walked every volume one directory at a time. On NTFS
that reads each directory's index and reaches the MFT records in directory
order, and on APFS it searches the catalog once per lookup, parsing the same
leaf again for every entry in it.
qnxprobe 1.30 reads both in one pass: NTFS from its $MFT and APFS from the
catalog's leaves. The seeker now takes that route and keeps its own
traversal, depth first with each directory's children sorted by name,
because the member list is the order search() hands an artifact its files
in. Every other filesystem is walked as before, and so is an NTFS volume
whose one-pass listing fails.
Old seeker against new, on the same acquisitions:
macOS Big Sur E01, 32 GB 139.8 s -> 8.5 s
Windows 11 E01, 49 GB 9.7 s -> 5.5 s
Windows 10 E01, 7.4 GB 4.3 s -> 2.3 s
The member lists are identical, order included, on every fixture, on the
macOS acquisition and on the 7.4 GB Windows 10 one. On two other Windows
acquisitions the one-pass route lists 3 more files, where a directory's
index holds an entry for the name at an older sequence number than the
file's own record: the directory walk rightly refuses the entry and so
loses a file whose record is live. On one of them a fourth path resolves
to a different record.
A full DLEAPP run on three acquisitions produced identical artifact
tables, and the macOS one went from 226.7 s to 85.7 s.
Re-vendors qnxprobe 1.29 -> 1.30 and adds the APFS fixture, which the
seeker had no test for.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reads NTFS and APFS images in one pass with qnxprobe 1.30, instead of one directory at a time.
$MFT, APFS from one pass over its catalog. Every other filesystem is walked as before.raw_image.pystays byte-identical across the five cores.Listing a 32 GB macOS E01 went from 139.8 s to 8.5 s, and a full DLEAPP run on it from 226.7 s to 85.7 s, with identical artifact tables. On two Windows acquisitions the new route lists 3 more files: live files whose directory index entry is stale.
🤖 Generated with Claude Code