Skip to content

[PUB-1041] OBJECT_SYNC spec#333

Merged
VeskeR merged 5 commits into
mainfrom
PUB-1041/object-sync
Sep 8, 2025
Merged

[PUB-1041] OBJECT_SYNC spec#333
VeskeR merged 5 commits into
mainfrom
PUB-1041/object-sync

Conversation

@VeskeR

@VeskeR VeskeR commented Jun 12, 2025 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

This is the spec equivalent of the object sync sequence handling in ably-js https://github.com/ably/ably-js/blob/main/src/plugins/objects/objects.ts#L215

Resolves PUB-1041

@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 12, 2025 08:46 Inactive
@VeskeR
VeskeR changed the base branch from main to objects-plugin June 12, 2025 08:46
sacOO7
sacOO7 reviewed Jun 12, 2025
View reviewed changes
Comment thread textile/objects-features.textile
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from d10e385 to 3336d98 Compare June 12, 2025 09:14
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 12, 2025 09:15 Inactive
@lawrence-forooghian lawrence-forooghian added the live-objects Related to LiveObjects functionality. label Jun 12, 2025
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch 2 times, most recently from 36792eb to cdb9d58 Compare June 12, 2025 23:37
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 12, 2025 23:37 Inactive
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from cdb9d58 to f4dd5d4 Compare June 13, 2025 00:15
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 13, 2025 00:15 Inactive
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from f4dd5d4 to b4d8e4d Compare June 13, 2025 02:04
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 13, 2025 02:05 Inactive
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from b4d8e4d to 948ad9b Compare June 13, 2025 08:40
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 13, 2025 08:40 Inactive
lawrence-forooghian
lawrence-forooghian reviewed Jun 17, 2025
View reviewed changes
Comment thread textile/objects-features.textile Outdated
Comment thread textile/objects-features.textile
Comment thread textile/objects-features.textile
Comment thread textile/objects-features.textile
Comment thread textile/objects-features.textile Outdated
Comment thread textile/objects-features.textile Outdated
Comment thread textile/objects-features.textile Outdated
Comment thread textile/objects-features.textile Outdated
Comment thread textile/objects-features.textile Outdated
Comment thread textile/objects-features.textile
lawrence-forooghian
lawrence-forooghian reviewed Jun 17, 2025
View reviewed changes
Comment thread textile/objects-features.textile Outdated
@VeskeR
VeskeR force-pushed the objects-plugin branch 3 times, most recently from bebe5fa to 5a6893a Compare June 19, 2025 03:00
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from 948ad9b to 39111b8 Compare June 19, 2025 03:05
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 19, 2025 03:06 Inactive
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from 39111b8 to 8a7c38e Compare June 19, 2025 03:06
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 19, 2025 03:07 Inactive
@VeskeR VeskeR mentioned this pull request Jun 19, 2025
Merged
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from 8a7c38e to 2335a1d Compare June 19, 2025 04:30
@github-actions
github-actions Bot temporarily deployed to staging/pull/333 June 19, 2025 04:30 Inactive
@lawrence-forooghian lawrence-forooghian mentioned this pull request Jul 11, 2025
Merged
lawrence-forooghian
lawrence-forooghian reviewed Jul 30, 2025
View reviewed changes
Comment thread textile/objects-features.textile
lawrence-forooghian added a commit that referenced this pull request Aug 4, 2025
@lawrence-forooghian
Fix nullability of ObjectsMapEntry.data
97c43cb 
I have observed it being absent for a tombstoned map entry received in
an OBJECT_SYNC. Also RTLM8a2a of #333 at dd25dca tells us to set it to
null.
@lawrence-forooghian lawrence-forooghian mentioned this pull request Aug 4, 2025
Merged
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from dd25dca to fc46aed Compare September 3, 2025 08:45
This was referenced Sep 4, 2025
Open
Open
@VeskeR
VeskeR force-pushed the PUB-1041/object-sync branch from bfcf05b to b3e06dc Compare September 5, 2025 07:48
@VeskeR
Make it clear what arguments are expected in RTLM7, RTLM8 and improve…
027ec46 
… phrasing in RTLM7*, RTLM8*, RTLM6d1a and RTLM6d1b

This uses phrasing initially added in 652daac commit
in #343 PR. It makes sense to
include those changes in this #333 PR
to make the OBJECT sync sequence and related spec items more clear.
@VeskeR
VeskeR requested review from owenpearson and sacOO7 September 5, 2025 13:52
sacOO7
sacOO7 approved these changes Sep 5, 2025
View reviewed changes

@sacOO7 sacOO7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ( You can recheck all review comments in case )

@VeskeR
VeskeR merged commit 6d1dabd into main Sep 8, 2025
2 checks passed
@VeskeR
VeskeR deleted the PUB-1041/object-sync branch September 8, 2025 08:22
ttypic pushed a commit that referenced this pull request Mar 6, 2026
@lawrence-forooghian
Fix nullability of ObjectsMapEntry.data
4acac7a 
I have observed it being absent for a tombstoned map entry received in
an OBJECT_SYNC. Also RTLM8a2a of #333 at dd25dca tells us to set it to
null.
ttypic pushed a commit that referenced this pull request Mar 6, 2026
@VeskeR
Make it clear what arguments are expected in RTLM7, RTLM8 and improve…
a5273d6 
… phrasing in RTLM7*, RTLM8*, RTLM6d1a and RTLM6d1b

This uses phrasing initially added in 652daac commit
in #343 PR. It makes sense to
include those changes in this #333 PR
to make the OBJECT sync sequence and related spec items more clear.
ttypic pushed a commit that referenced this pull request Mar 6, 2026
@VeskeR
Merge pull request #333 from ably/PUB-1041/object-sync
7db45b1 
[PUB-1041] OBJECT_SYNC spec
ttypic pushed a commit that referenced this pull request Mar 6, 2026
@lawrence-forooghian
Fix nullability of ObjectsMapEntry.data
7d5d082 
I have observed it being absent for a tombstoned map entry received in
an OBJECT_SYNC. Also RTLM8a2a of #333 at dd25dca tells us to set it to
null.
ttypic pushed a commit that referenced this pull request Mar 6, 2026
@VeskeR
Make it clear what arguments are expected in RTLM7, RTLM8 and improve…
cee6486 
… phrasing in RTLM7*, RTLM8*, RTLM6d1a and RTLM6d1b

This uses phrasing initially added in 652daac commit
in #343 PR. It makes sense to
include those changes in this #333 PR
to make the OBJECT sync sequence and related spec items more clear.
ttypic pushed a commit that referenced this pull request Mar 6, 2026
@VeskeR
Merge pull request #333 from ably/PUB-1041/object-sync
8eab509 
[PUB-1041] OBJECT_SYNC spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes
@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes
@owenpearson owenpearson Awaiting requested review from owenpearson

Assignees

No one assigned

Labels

live-objects Related to LiveObjects functionality.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VeskeR @lawrence-forooghian @sacOO7 @owenpearson