Conversation
The krunkit driver only supports virtiofs and reverse-sshfs, but the mount
type was resolved to 9p for krunkit, so the VM failed to start with:
field `mountType` must be `virtiofs` or `reverse-sshfs` for krunkit driver, got `9p`
cmd/start.go already treats krunkit as a virtiofs VM type (it rewrites 9p to
virtiofs for krunkit), so resolve the mount type the same way in yaml.go.
Add Test_config_MountType covering krunkit, vz and qemu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
colima start --vm-type krunkit(without an explicit--mount-type) fails to boot the VM:Reproduced with colima v0.10.3 on macOS 26.3.2 (Apple Silicon), krunkit 1.3.2.
Cause
cmd/start.goalready knows krunkit is a virtiofs VM type (it does not downgradevirtiofstosshfsfor krunkit, and it rewrites9ptovirtiofs), butenvironment/vm/lima/yaml.goresolves the Lima mount type as:so for
krunkitthe mount type ends up as9p, which the krunkit driver rejects.Fix
Resolve
virtiofsfor krunkit the same way as for vz. qemu keeps using9p.Tests
Added
Test_config_MountTypecovering krunkit/vz/qemu withvirtiofs,9pandsshfs.Without the fix the new test fails with:
Workaround until this is released:
colima start --vm-type krunkit --mount-type sshfs.