UN-4128 [FIX] Stop the pipeline/ETL list page from 500ing - #2291
Merged
kirtimanmishrazipstack merged 4 commits intoSep 18, 2026
Merged
Conversation
…ing guard PipelineSerializer.get_fields() (UN-2868, #2273) scopes the workflow field to the requester's own workflows, guarding the single-instance case with `self.instance is not None`. On a list request DRF hands the child serializer of a many=True ListSerializer the whole queryset as self.instance, not one row -- `is not None` let that through and `.workflow_id` crashed on a list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018KZLGSa3oWxgVJdFqvRUQX
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Covers the AttributeError DRF's paginated list GET triggers when self.instance is a list instead of a Pipeline or None. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Greptile asked for a test that exercises PipelineSerializer(queryset, many=True) directly instead of hand-setting self.instance. DRF's many_init passes the same instance to the child, so both paths already caught the regression, but this removes any doubt. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Contributor
Unstract test resultsPer-group results
Critical paths
|
chandrasekharan-zipstack
approved these changes
Sep 18, 2026
kirtimanmishrazipstack
deleted the
UN-4128-pipeline-list-serializer-crash
branch
September 18, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Pipeline, not just non-empty —isinstance(self.instance, Pipeline)in place ofself.instance is not None. Detail and update requests are unaffected; only the list request was ever passing a non-Pipelinevalue here.Can this PR break any existing features? If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
mainin — unrelated to that PR's own changes.Dependencies Versions
Notes on Testing
many=TrueraisedAttributeError: 'list' object has no attribute 'workflow_id'onmain; confirmed it no longer does with this fix. Manually verified against a local ETL pipeline list page.Screenshots
Checklist
I have read and understood the Contribution Guidelines.
🤖 Generated with Claude Code
https://claude.ai/code/session_018KZLGSa3oWxgVJdFqvRUQX